Messages in this thread | | | Date | Tue, 31 May 2022 16:40:08 +0100 | Subject | Re: [PATCH] MIPS: fix pmd_mkinvalid | From | Jiaxun Yang <> |
| |
在 2022/5/31 5:36, Hongchen Zhang 写道: > pmd_mkinvalid should not clear dirty flag,otherwise the pmd > dirty flag,it's ok to just clear _PAGE_VALID. Hi Hongcheng,
Sorry, what is meant by "otherwise the pmd dirty flag"? Could you please elaborate? In my humble opinion _PAGE_PRESENT must be cleared in mkinvalid as it nolonger present here. And thus it lose the dirty status.
Thanks - Jiaxun
> Signed-off-by: Hongchen Zhang <zhanghongchen@loongson.cn> > --- > arch/mips/include/asm/pgtable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h > index 374c632..d30a186 100644 > --- a/arch/mips/include/asm/pgtable.h > +++ b/arch/mips/include/asm/pgtable.h > @@ -698,7 +698,7 @@ static inline pmd_t pmd_modify(pmd_t pmd, pgprot_t newprot) > > static inline pmd_t pmd_mkinvalid(pmd_t pmd) > { > - pmd_val(pmd) &= ~(_PAGE_PRESENT | _PAGE_VALID | _PAGE_DIRTY); > + pmd_val(pmd) &= ~_PAGE_VALID; > > return pmd; > }
| |