lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: dt-bindings: Move 'rx-sample-delay-ns' to spi-peripheral-props.yaml
On Fri, May 27, 2022 at 02:32:26PM +0300, Serge Semin wrote:
> On Thu, May 26, 2022 at 08:54:04AM -0500, Rob Herring wrote:
> > On Thu, May 26, 2022 at 11:16:42AM +0530, Pratyush Yadav wrote:
> > > Hi Rob,
> > >
> > > On 25/05/22 04:00PM, Rob Herring wrote:
> > > > SPI bus per device properties must be defined in spi-peripheral-props.yaml
> > > > for unevaluatedProperties checks to work correctly on device nodes.
> > > >
> > > > This has the side effect of promoting 'rx-sample-delay-ns' to be a
> > > > common property, but functionally it's no different if it was defined in
> > > > a Synopsys specific schema file.
> > >
> > > Functionally it is no different, but does this property make sense for
> > > other controllers? If not then I don't see why we should pollute the
> > > common list with controller-specific ones. For one, this now no longer
> > > makes it obvious that this property should only be used with the
> > > Synopsys controller. And if you keep making small exceptions for other
> > > controllers too, soon the common list will be full of controller
> > > properties and it will be a mess finding out what belongs to who.
> >
>
> > There's at least one other case already:
> >
> > cdns,read-delay:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description:
> > Delay for read capture logic, in clock cycles.
>
> What about creating the schemas hierarchy for the device-specific
> properties as I already suggested in the other thread? Like this:
>
> https://lore.kernel.org/linux-ide/20220527101057.b5z7ase6y4naoxvk@mobilestation

Because that doesn't work. I'll explain in that thread.

Rob

\
 
 \ /
  Last update: 2022-05-31 17:11    [W:0.057 / U:1.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site