Messages in this thread | | | Date | Tue, 31 May 2022 09:45:05 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 10/31] devfreq: exynos: Migrate to dev_pm_opp_set_config() |
| |
On 31-05-22, 13:12, Chanwoo Choi wrote: > I try to find the cause of this warning. > I think that dev_pm_opp_clear_config needs to check > whether 'opp_table' is NULL or not as following: > > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index fba6e2b20b8f..cbf8f10b9ff0 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -2598,6 +2598,9 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_set_config); > */ > void dev_pm_opp_clear_config(struct opp_table *opp_table) > { > + if (unlikely(!opp_table)) > + return; > + > if (opp_table->genpd_virt_devs) > dev_pm_opp_detach_genpd(opp_table);
Does this fixes it for you ?
It isn't allowed to call this routine with opp_table as NULL, I should rather have a WARN() for the same instead.
Can you check why exynos is passing NULL here as I don't see an obvious reason currently.
-- viresh
| |