Messages in this thread | | | Date | Tue, 31 May 2022 20:43:25 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v2 2/3] net: skb: use auto-generation to convert skb drop reason to string |
| |
On Wed, 1 Jun 2022 11:27:41 +0800 Menglong Dong wrote: > > > +#include <linux/kernel.h> > > > > Why? > > Oh, you noticed it. To simplify the code in dropreason_str.c, as > EXPORT_SYMBOL() is used. Okay, I'll move it to the generation > part.
IMHO you can move the EXPORT_SYMBOL() to skbuff.c, with a comment saying that the array itself is in an auto-generated source. Avoid avoid to "echo" both the EXPORT and the include.
| |