Messages in this thread | | | Subject | Re: [PATCH v3 09/16] arch_topology: Drop LLC identifier stash from the CPU topology | From | Gavin Shan <> | Date | Wed, 1 Jun 2022 11:35:20 +0800 |
| |
Hi Sudeep,
On 5/25/22 4:14 PM, Sudeep Holla wrote: > Since the cacheinfo LLC information is used directly in arch_topology, > there is no need to parse and store the LLC ID information only for > ACPI systems in the CPU topology. > > Remove the redundant LLC ID from the generic CPU arch_topology information. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/base/arch_topology.c | 1 - > include/linux/arch_topology.h | 1 - > 2 files changed, 2 deletions(-) >
How about merge the changes to PATCH[08/16]? I don't see why we need put the changes into separate patches.
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 4c486e4e6f2f..76c702c217c5 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -747,7 +747,6 @@ void __init reset_cpu_topology(void) > cpu_topo->core_id = -1; > cpu_topo->cluster_id = -1; > cpu_topo->package_id = -1; > - cpu_topo->llc_id = -1; > > clear_cpu_topology(cpu); > } > diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h > index 58cbe18d825c..a07b510e7dc5 100644 > --- a/include/linux/arch_topology.h > +++ b/include/linux/arch_topology.h > @@ -68,7 +68,6 @@ struct cpu_topology { > int core_id; > int cluster_id; > int package_id; > - int llc_id; > cpumask_t thread_sibling; > cpumask_t core_sibling; > cpumask_t cluster_sibling; >
Thanks, Gavin
| |