lkml.org 
[lkml]   [2022]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.18 044/159] ASoC: rsnd: care default case on rsnd_ssiu_busif_err_status_clear()
    Date
    From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    [ Upstream commit b1384d4c95088d01f4266237faabf165d3d605fc ]

    commit cfb7b8bf1e2d66 ("ASoC: rsnd: tidyup
    rsnd_ssiu_busif_err_status_clear()") merged duplicate code, but it didn't
    care about default case, and causes smatch warnings.

    smatch warnings:
    sound/soc/sh/rcar/ssiu.c:112 rsnd_ssiu_busif_err_status_clear() \
    error: uninitialized symbol 'offset'.
    sound/soc/sh/rcar/ssiu.c:114 rsnd_ssiu_busif_err_status_clear() \
    error: uninitialized symbol 'shift'.

    This patch cares it.

    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Link: https://lore.kernel.org/r/87r15rgn6p.wl-kuninori.morimoto.gx@renesas.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/sh/rcar/ssiu.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
    index 0d8f97633dd2..138f95dd9f4a 100644
    --- a/sound/soc/sh/rcar/ssiu.c
    +++ b/sound/soc/sh/rcar/ssiu.c
    @@ -102,6 +102,8 @@ bool rsnd_ssiu_busif_err_status_clear(struct rsnd_mod *mod)
    shift = 1;
    offset = 1;
    break;
    + default:
    + goto out;
    }

    for (i = 0; i < 4; i++) {
    @@ -120,7 +122,7 @@ bool rsnd_ssiu_busif_err_status_clear(struct rsnd_mod *mod)
    }
    rsnd_mod_write(mod, reg, val);
    }
    -
    +out:
    return error;
    }

    --
    2.35.1
    \
     
     \ /
      Last update: 2022-05-30 15:32    [W:4.097 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site