Messages in this thread | | | Date | Mon, 30 May 2022 14:00:35 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC][PATCH 3/9] cpuidle: Move IRQ state validation |
| |
On Mon, May 30, 2022 at 01:36:40PM +0200, Frederic Weisbecker wrote: > On Thu, May 19, 2022 at 11:27:53PM +0200, Peter Zijlstra wrote: > > Make cpuidle_enter_state() consistent with the s2idle variant and > > verify ->enter() always returns with interrupts disabled. > > > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > --- > > drivers/cpuidle/cpuidle.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > --- a/drivers/cpuidle/cpuidle.c > > +++ b/drivers/cpuidle/cpuidle.c > > @@ -234,7 +234,11 @@ int cpuidle_enter_state(struct cpuidle_d > > stop_critical_timings(); > > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > > rcu_idle_enter(); > > + > > entered_state = target_state->enter(dev, drv, index); > > + if (WARN_ON_ONCE(!irqs_disabled())) > > + raw_local_irq_disable(); > > So it means that idle functions are supposed to return with IRQs disabled > without tracing, right? I can see that at least acpi_safe_halt() is using > the non-raw local_irq_disable().
Yeah, I might need to re-order this. 0day also complained about that. I'll need to find a moment to re-audit this and put it in the right place.
| |