Messages in this thread | | | Subject | Re: [PATCH v2] ath11k: mhi: fix potential memory leak in ath11k_mhi_register() | From | Kalle Valo <> | Date | Mon, 30 May 2022 11:32:05 +0000 (UTC) |
| |
Jianglei Nie <niejianglei2021@163.com> wrote:
> mhi_alloc_controller() allocates a memory space for mhi_ctrl. When some > errors occur, mhi_ctrl should be freed by mhi_free_controller() and set > ab_pci->mhi_ctrl = NULL because ab_pci->mhi_ctrl has a dangling pointer > to the freed memory. But when ath11k_mhi_read_addr_from_dt() fails, the > function returns without calling mhi_free_controller(), which will lead > to a memory leak. > > We can fix it by calling mhi_free_controller() when > ath11k_mhi_read_addr_from_dt() fails and set ab_pci->mhi_ctrl = NULL in > all of the places where we call mhi_free_controller(). > > Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Please always include a changelog from previous version:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
No need to resend because of this, a reply to this email is sufficient.
-- https://patchwork.kernel.org/project/linux-wireless/patch/20220530080610.143925-1-niejianglei2021@163.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |