Messages in this thread | | | Date | Mon, 30 May 2022 09:51:23 +0530 | Subject | Re: [PATCH v2 1/6] ASoC: tegra: Add binding doc for OPE module | From | Sameer Pujar <> |
| |
On 29-05-2022 19:39, Krzysztof Kozlowski wrote: > On 27/05/2022 12:26, Sameer Pujar wrote: >> This patch adds YAML schema for DT bindings of Output Processing >> Engine (OPE) module. It consists of Parametric Equalizer (PEQ) >> and Multi Band Dynamic Range Compressor (MBDRC) sub blocks and >> binding doc for these blocks are added as well. The OPE will be >> registered as an ASoC component and can be plugged into an audio >> path as per need via ALSA mixer controls. The DT bindings are >> applicable on Tegra210 and later SoCs where OPE module is present. >> >> Signed-off-by: Sameer Pujar <spujar@nvidia.com> >> --- >> .../bindings/sound/nvidia,tegra210-ahub.yaml | 4 + >> .../bindings/sound/nvidia,tegra210-mbdrc.yaml | 47 ++++++++++++ >> .../bindings/sound/nvidia,tegra210-ope.yaml | 87 ++++++++++++++++++++++ >> .../bindings/sound/nvidia,tegra210-peq.yaml | 48 ++++++++++++ >> 4 files changed, 186 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml >> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml >> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-peq.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml >> index 6df6f85..47b6e71 100644 >> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml >> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml >> @@ -110,6 +110,10 @@ patternProperties: >> type: object >> $ref: nvidia,tegra186-asrc.yaml# >> >> + '^processing-engine@[0-9a-f]+$': >> + type: object >> + $ref: nvidia,tegra210-ope.yaml# >> + >> required: >> - compatible >> - reg >> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml >> new file mode 100644 >> index 0000000..0d55328 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mbdrc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Tegra210 MBDRC Device Tree Bindings > Previous comments - s/Device Tree Bindings// > - still applies. Please do not ignore it.
I did not ignore this. There was a comment from Mark on this earlier (v1) and I did not see further reply from you. I thought you were OK with the way it is. So if you are saying acronym part is OK and just to remove "Device Tree Bindings" I can send a v3 for this.
| |