Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 30 May 2022 11:38:04 +0200 | Subject | Re: [RFC PATCH v1 0/9] deferred_probe_timeout logic clean up |
| |
Hi Saravana,
On Thu, May 26, 2022 at 10:15 AM Saravana Kannan <saravanak@google.com> wrote: > This series is based on linux-next + these 2 small patches applies on top: > https://lore.kernel.org/lkml/20220526034609.480766-1-saravanak@google.com/ > > A lot of the deferred_probe_timeout logic is redundant with > fw_devlink=on. Also, enabling deferred_probe_timeout by default breaks > a few cases. > > This series tries to delete the redundant logic, simplify the frameworks > that use driver_deferred_probe_check_state(), enable > deferred_probe_timeout=10 by default, and fixes the nfsroot failure > case. > > Patches 1 to 3 are fairly straightforward and can probably be applied > right away. > > Patches 4 to 9 are related and are the complicated bits of this series. > > Patch 8 is where someone with more knowledge of the IP auto config code > can help rewrite the patch to limit the scope of the workaround by > running the work around only if IP auto config fails the first time > around. But it's also something that can be optimized in the future > because it's already limited to the case where IP auto config is enabled > using the kernel commandline.
Thanks for your series!
> Yoshihiro/Geert, > > If you can test this patch series and confirm that the NFS root case > works, I'd really appreciate that.
On Salvator-XS, Micrel KSZ9031 Gigabit PHY probe is no longer delayed by 9s after applying the two earlier patches, and the same is true after applying this series on top. Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
I will do testing on more boards, but that may take a while, as we're in the middle of the merge window.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |