lkml.org 
[lkml]   [2022]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 2/6] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver
From


On 5/30/22 18:57, Dmitry Torokhov wrote:
> Hi Randy,
>
> On Mon, May 30, 2022 at 06:26:26PM -0700, Randy Dunlap wrote:
>> Hi--
>>
>> On 4/19/22 13:51, Charles Mirabile wrote:
>>> diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
>>> index 3b23078bc7b5..505a032e2786 100644
>>> --- a/drivers/input/joystick/Kconfig
>>> +++ b/drivers/input/joystick/Kconfig
>>> @@ -399,4 +399,15 @@ config JOYSTICK_N64
>>> Say Y here if you want enable support for the four
>>> built-in controller ports on the Nintendo 64 console.
>>>
>>> +config JOYSTICK_SENSEHAT
>>> + tristate "Raspberry Pi Sense HAT joystick"
>>> + depends on INPUT && I2C
>>> + select MFD_SIMPLE_MFD_I2C
>>
>> Looks like this also needs
>> depends on HAS_IOMEM
>>
>> since everything in drivers/mfd/Kconfig depends on HAS_IOMEM and
>> since this 'select' causes a kconfig warning when HAS_IOMEM is not set:
>>
>> WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C
>> Depends on [n]: HAS_IOMEM [=n] && I2C [=y]
>> Selected by [y]:
>> - JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y]
>
> Do you mind sending a patch?

OK, will do.

--
~Randy

\
 
 \ /
  Last update: 2022-05-31 04:15    [W:0.084 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site