lkml.org 
[lkml]   [2022]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 54/55] eth: tg3: silence the GCC 12 array-bounds warning
    Date
    From: Jakub Kicinski <kuba@kernel.org>

    [ Upstream commit 9dec850fd7c210a04b4707df8e6c95bfafdd6a4b ]

    GCC 12 currently generates a rather inconsistent warning:

    drivers/net/ethernet/broadcom/tg3.c:17795:51: warning: array subscript 5 is above array bounds of ‘struct tg3_napi[5]’ [-Warray-bounds]
    17795 | struct tg3_napi *tnapi = &tp->napi[i];
    | ~~~~~~~~^~~

    i is guaranteed < tp->irq_max which in turn is either 1 or 5.
    There are more loops like this one in the driver, but strangely
    GCC 12 dislikes only this single one.

    Silence this silliness for now.

    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/Makefile | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/net/ethernet/broadcom/Makefile b/drivers/net/ethernet/broadcom/Makefile
    index 7046ad6d3d0e..ac50da49ca77 100644
    --- a/drivers/net/ethernet/broadcom/Makefile
    +++ b/drivers/net/ethernet/broadcom/Makefile
    @@ -16,3 +16,8 @@ obj-$(CONFIG_BGMAC_BCMA) += bgmac-bcma.o bgmac-bcma-mdio.o
    obj-$(CONFIG_BGMAC_PLATFORM) += bgmac-platform.o
    obj-$(CONFIG_SYSTEMPORT) += bcmsysport.o
    obj-$(CONFIG_BNXT) += bnxt/
    +
    +# FIXME: temporarily silence -Warray-bounds on non W=1+ builds
    +ifndef KBUILD_EXTRA_WARN
    +CFLAGS_tg3.o += -Wno-array-bounds
    +endif
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-05-30 16:39    [W:2.776 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site