lkml.org 
[lkml]   [2022]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible
    Hi,

    On Mon, May 2, 2022 at 9:22 PM Stephen Boyd <swboyd@chromium.org> wrote:
    >
    > @@ -113,3 +135,56 @@ examples:
    > /* UP LEFT */
    > 0x070b0067 0x070c0069>;
    > };
    > +
    > + - |
    > + keyboard-controller {
    > + compatible = "google,cros-ec-keyb-switches", "google,cros-ec-keyb";
    > + /* Matrix keymap properties are allowed but ignored */

    nit: s/allowed/required/

    This now looks reasonable and well explained to me.

    Reviewed-by: Douglas Anderson <dianders@chromium.org>

    \
     
     \ /
      Last update: 2022-05-03 17:09    [W:4.608 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site