lkml.org 
[lkml]   [2022]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v1 2/4] ipc: Use proper ipc namespace
    Date
    On Mon, May 02, 2022 at 11:09:22AM -0500, Eric W. Biederman wrote:
    > Alexey Gladkov <legion@kernel.org> writes:
    >
    > > As Eric Biederman pointed out, changing the namespace broke checkpoint
    > > restore. I have reverted my previous changes.
    >
    > Can you remind me the bug that is being fixed here?
    >
    > I am probably just going to fast to see it, but it would be good to have
    > it described in the commit comment.

    It was preparation for the "ipc: Check permissions for checkpoint_restart
    sysctls at open time". I wanted to split the commit and make it more readable,
    but it looks like I just confused everyone. This change should be part of the
    next commit.

    Here is a new version of the patchset where I moved the bugfix to a separate
    commit as you requested in the next email.

    Does that look better?

    --

    Alexey Gladkov (4):
    ipc: Use the same namespace to modify and validate
    ipc: Remove extra1 field abuse to pass ipc namespace
    ipc: Check permissions for checkpoint_restart sysctls at open time
    ipc: Remove extra braces

    ipc/ipc_sysctl.c | 108 +++++++++++++++++++++--------------------------
    1 file changed, 49 insertions(+), 59 deletions(-)

    --
    2.33.3

    \
     
     \ /
      Last update: 2022-05-03 17:08    [W:3.553 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site