Messages in this thread | | | From | "Hawkins, Nick" <> | Subject | RE: [PATCH v6 7/8] ARM: dts: Introduce HPE GXP Device tree | Date | Tue, 3 May 2022 14:08:31 +0000 |
| |
On 02/05/2022 22:40, nick.hawkins@hpe.com wrote: > > From: Nick Hawkins <nick.hawkins@hpe.com> > > > > The HPE SoC is new to linux. A basic device tree layout with minimum > > required for linux to boot including a timer and watchdog support has > > been created. > > > > The dts file is empty at this point but will be updated in subsequent > > updates as board specific features are enabled. > > > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > > > > --- > > v6: > > * Added cache-controller to CPU > > * Removed hpe,gxp-wdt and removed simple-mfd from hpe,gxp-timer > > * Added space after ',' in compatible lists containing more than one > > item
> Hmmm....
> > integratorap-im-pd1.dtb \ > > diff --git a/arch/arm/boot/dts/hpe-bmc-dl360gen10.dts > > b/arch/arm/boot/dts/hpe-bmc-dl360gen10.dts > > new file mode 100644 > > index 000000000000..69e9c6672ea8 > > --- /dev/null > > +++ b/arch/arm/boot/dts/hpe-bmc-dl360gen10.dts > > @@ -0,0 +1,13 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree file for HPE DL360Gen10 */ > > + > > +/include/ "hpe-gxp.dtsi" > > + > > +/ { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "hpe,gxp-dl360gen10","hpe,gxp";
> Missing space after ','
> With this fixed: > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I forgot to check this file while fixing the spacing. Thank you for your review and apologies about missing this.
Thanks,
-Nick Hawkins
| |