lkml.org 
[lkml]   [2022]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 5/8] dt-bindings: timer: hpe,gxp-timer: Creation
From
On 02/05/2022 22:40, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> Add support for the HPE GXP Timer and Watchdog. There are multiple
> timers on the SoC but only one is enabled at this time.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
>
> ---
> v6:
> * Removed simple-mfd compatible, timer will create watchdog without
> watchdog node.
> * Removed timer0 label
> * Changed title from HPE GXP TIMER to HPE GXP Timer
> * Changed clock name iopclk to iop
> * Set additionalProperties to false
> * Added space after ',' in the compatible list
> * Changed subject to match the log better

The subject after prefixes does not match it better. What is "creation"?
"Add HPE GXP Timer and Watchdog"

Rest is okay, so this could be fixed while applying (if you are going to
resend, don't loose that comment and don't loose the tag):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-03 12:00    [W:0.126 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site