Messages in this thread | | | Date | Tue, 3 May 2022 09:23:07 +0200 | Subject | Re: [PATCH V7 3/6] x86/entry: Move PUSH_AND_CLEAR_REGS out of error_entry() | From | Juergen Gross <> |
| |
On 03.05.22 05:21, Lai Jiangshan wrote: > From: Lai Jiangshan <jiangshan.ljs@antgroup.com> > > The macro idtentry calls error_entry() unconditionally even on XENPV. > But the code XENPV needs in error_entry() is PUSH_AND_CLEAR_REGS only. > > And PUSH_AND_CLEAR_REGS in error_entry() makes the stack not return to > its original place when the function returns, which means it is not > possible to convert it to a C function. > > Move PUSH_AND_CLEAR_REGS out of error_entry(), add a function to wrap > PUSH_AND_CLEAR_REGS and call it before error_entry(). > > It will allow for error_entry() to be not called on XENPV and for > error_entry() to be converted to C code. > > Cc: Juergen Gross <jgross@suse.com> > Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |