lkml.org 
[lkml]   [2022]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] irqchip/armada-370-xp: Enable MSI affinity configuration
    On Sun, 24 Apr 2022 at 02:21, Andrew Lunn <andrew@lunn.ch> wrote:
    >
    > On Fri, Apr 22, 2022 at 10:58:23PM +1000, Nathan Rossi wrote:
    > > On Fri, 22 Apr 2022 at 22:19, Andrew Lunn <andrew@lunn.ch> wrote:
    > > >
    > > > > If you have a PCIe device that you can use with the 370 rd.
    > > >
    > > > Sorry, nothing on its bus.
    > > >
    > > > The only device i have which might make sense testing is a
    > > > WRT1900ac. That has an Armada XP dual core. I could try building a UP
    > > > kernel for it, but i guess you have tried that already with your
    > > > machine in order to test a UP setup?
    > >
    > > I have tested with SMP=n on a Armada 385 without any issues. So no
    > > need to do that on the Armada XP.
    > >
    > > There is still value in testing on the WRT1900ac device since so far I
    > > have only tested on a Armada 385. The Armada XP does have
    > > registers/etc. of the MPIC very similar to the 370, compared to the
    > > 385 having some significant differences. So if it is not too
    > > problematic to test on (it appears to have its wifi attached via
    > > PCIe?) please do.
    >
    > Hi Nathan
    >
    > Turns out the WiFi drivers are in a sorry state. There is no mainline
    > driver. There is an OpenWRT driver, but it has not been updated for a
    > few years, tries to use get_fs() set_fs() pci_map_single() etc.
    >
    > I've mostly used this platform for Ethernet switch development, so
    > i've never tried the WiFi before. I had no idea it was so broken...
    >
    > So sorry, i cannot test this.

    Thanks for giving it a try.

    I managed to source an existing one of our products that uses an
    Armada 370 with a PCIe device attached. Took me a bit to get a recent
    kernel booting on it, however I was able to confirm that this MSI
    affinity change works correctly on the 370 SoC (with and without
    CONFIG_SMP).

    Regards,
    Nathan

    \
     
     \ /
      Last update: 2022-05-04 02:38    [W:3.119 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site