lkml.org 
[lkml]   [2022]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 24/26] dmaengine: dw-edma: Skip cleanup procedure if no private data found
    Date
    DW eDMA driver private data is preserved in the passed DW eDMA chip info
    structure. If either probe procedure failed or for some reason the passed
    info object doesn't have private data pointer initialized we need to halt
    the DMA device cleanup procedure in order to prevent possible system
    crashes.

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    ---
    drivers/dma/dw-edma/dw-edma-core.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
    index 908607785401..561686b51915 100644
    --- a/drivers/dma/dw-edma/dw-edma-core.c
    +++ b/drivers/dma/dw-edma/dw-edma-core.c
    @@ -1035,6 +1035,10 @@ int dw_edma_remove(struct dw_edma_chip *chip)
    struct dw_edma *dw = chip->dw;
    int i;

    + /* Skip removal if no private data found */
    + if (!dw)
    + return -ENODEV;
    +
    /* Disable eDMA */
    dw_edma_v0_core_off(dw);

    --
    2.35.1
    \
     
     \ /
      Last update: 2022-05-04 00:54    [W:4.179 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site