lkml.org 
[lkml]   [2022]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding
On Fri, Apr 29, 2022 at 03:13:48PM +0200, Pali Rohár wrote:
> GPIO is optional and used for WDI logic.

Nowhere is WDI defined.

>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> index ab9641e845db..a97aa0135ef9 100644
> --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> @@ -27,6 +27,10 @@ properties:
> description: This is a 1-byte memory-mapped address
> maxItems: 1
>
> + gpios:

Usually, we want a name here. Maybe wdi-gpios, but I don't know what WDI
is nor have I read the pin name in the datasheet for inspiration.

> + description: Optional GPIO used for controlling WDI when WDI bit is not mapped to memory
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.20.1
>
>

\
 
 \ /
  Last update: 2022-05-03 23:53    [W:0.268 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site