Messages in this thread | | | Date | Sun, 29 May 2022 09:17:09 +0200 | Subject | Re: [PATCH] spi: rockchip: Fix a resource that is put twice in rockchip_spi_remove() | From | Christophe JAILLET <> |
| |
Le 29/05/2022 à 09:07, Christophe JAILLET a écrit : > spi_controller_put() is already called as part of > spi_unregister_controller(). The latter is called automatically because > the controller has been registered with the devm_ function. > > Remove the duplicate call. > > Fixes: 64e36824b32b ("spi/rockchip: add driver for Rockchip RK3xxx SoCs integrated SPI") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/spi/spi-rockchip.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > index a08215eb9e14..70777731b20e 100644 > --- a/drivers/spi/spi-rockchip.c > +++ b/drivers/spi/spi-rockchip.c > @@ -963,8 +963,6 @@ static int rockchip_spi_remove(struct platform_device *pdev) > if (ctlr->dma_rx) > dma_release_channel(ctlr->dma_rx); > > - spi_controller_put(ctlr); > - > return 0; > } >
NAK.
There is a spi_controller_get() call a few lines above, so this additional spi_controller_put() is needed.
CJ
| |