Messages in this thread | | | Date | Sun, 29 May 2022 15:04:26 +0800 | Subject | Re: [PATCH v2] erofs: leave compressed inodes unsupported in fscache mode for now | From | Chao Yu <> |
| |
On 2022/5/26 9:03, Jeffle Xu wrote: > erofs over fscache doesn't support the compressed layout yet. It will > cause NULL crash if there are compressed inodes contained when working > in fscache mode. > > So far in the erofs based container image distribution scenarios > (RAFS v6), the compressed RAFS v6 images are downloaded and then > decompressed on demand as an uncompressed erofs image. Then the erofs > image is mounted in fscache mode for containers to use. IOWs, currently > compressed data is decompressed on the userspace side instead and > uncompressed erofs images will be finally cached. > > The fscache support for the compressed layout is still under > development and it will be used for runtime decompression feature. > Anyway, to avoid the potential crash, let's leave the compressed inodes > unsupported in fscache mode until we support it later. > > Fixes: 1442b02b66ad ("erofs: implement fscache-based data read for non-inline layout") > Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> > Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
| |