Messages in this thread | | | From | Ming Qian <> | Subject | RE: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data | Date | Mon, 30 May 2022 02:50:20 +0000 |
| |
> From: Nicolas Dufresne <nicolas@ndufresne.ca> > Sent: 2022年5月28日 3:26 > To: Ming Qian <ming.qian@nxp.com>; Fabio Estevam <festevam@gmail.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mirela Rabulea (OSS) > <mirela.rabulea@oss.nxp.com>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; > Shawn Guo <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; > Sascha Hauer <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; > linux-media <linux-media@vger.kernel.org>; linux-kernel > <linux-kernel@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; moderated > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > <linux-arm-kernel@lists.infradead.org> > Subject: Re: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before > the configuration data > > Caution: EXT Email > > Le vendredi 27 mai 2022 à 11:33 +0000, Ming Qian a écrit : > > > From: Fabio Estevam <festevam@gmail.com> > > > Sent: 2022年5月27日 19:12 > > > To: Ming Qian <ming.qian@nxp.com> > > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mirela Rabulea (OSS) > > > <mirela.rabulea@oss.nxp.com>; Hans Verkuil > > > <hverkuil-cisco@xs4all.nl>; Shawn Guo <shawnguo@kernel.org>; Sascha > > > Hauer <s.hauer@pengutronix.de>; Sascha Hauer > > > <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; > > > linux-media <linux-media@vger.kernel.org>; linux-kernel > > > <linux-kernel@vger.kernel.org>; open list:OPEN FIRMWARE AND > > > FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; > > > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > > <linux-arm-kernel@lists.infradead.org> > > > Subject: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space > > > before the configuration data > > > > > > Caution: EXT Email > > > > > > Hi Ming, > > > > > > On Fri, May 27, 2022 at 7:25 AM Ming Qian <ming.qian@nxp.com> wrote: > > > > > > > > There is a hardware bug that it will load the first 128 bytes of > > > > configuration data twice, it will led to some configure error. > > > > so shift the configuration data 128 bytes, and make the first 128 > > > > bytes all zero, then hardware will load the 128 zero twice, and > > > > ignore them as garbage. > > > > then the configuration data can be loaded correctly > > > > > > > > Signed-off-by: Ming Qian <ming.qian@nxp.com> > > > > Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com> > > > > Reviewed-by: Tommaso Merciai > > > > <tommaso.merciai@amarulasolutions.com> > > > > > > Fixes tag? > > > > Hi Fabio, > > It's a hardware issue, so I'm not sure is it a driver issue that I fix it. > > Or I just check which patch includes the code I changed, and add > > the fix tag? > > You can use Fixes tag even though there was no software bug. The point of the > tag is to help locate how far we can backport this patch in order to let stable > kernel users benefit. > > regards, > Nicolas >
Hi Nicolas, Thanks for your information, I'll add a fix tag in v3. Ming.
> > > > Ming
| |