Messages in this thread | | | Date | Sun, 29 May 2022 16:00:01 +0200 | Subject | Re: [PATCH 2/3] [PATCH] dt-bindings: arm: add BCM6878 soc to binding document | From | Krzysztof Kozlowski <> |
| |
On 27/05/2022 19:09, Anand Gore wrote: > Add BCM6878 SOC device tree description to bcmbca binding document. > > Signed-off-by: Anand Gore <anand.gore@broadcom.com>
Your subject is corrupted. Anyway you made it a bit over-complicated. No need to say "to binding document" as the prefix explains it. So this should be (don't forget the actual subarch prefix):
dt-bindings: arm: brcm: add BCM6878 soc
Same applies to your other patches.
> --- > > .../devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > index a63e355ba8f9..4b4af2b1f277 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > @@ -43,6 +43,14 @@ properties: > - const: brcm,bcmbca > > > + - description: BCM6878 based boards > + items: > + - enum: > + - brcm,bcm96878 > + - const: brcm,bcm6878 > + - const: brcm,bcmbca > + > +
Same as before - no need for two blank lines.
> additionalProperties: true > > ...
Best regards, Krzysztof
| |