Messages in this thread |  | | Date | Sat, 28 May 2022 09:35:08 +0200 | From | Jimmy Assarsson <> | Subject | Re: [PATCH 10/12] can: kvaser_usb_leaf: Fix wrong CAN state after stopping |
| |
On 5/16/22 15:47, Anssi Hannula wrote: > 0bfd:0124 Kvaser Mini PCI Express 2xHS FW 4.18.778 sends a > CMD_CHIP_STATE_EVENT indicating bus-off after stopping the device, > causing a stopped device to appear as CAN_STATE_BUS_OFF instead of > CAN_STATE_STOPPED. > > Fix that by not handling error events on stopped devices. > > Fixes: 080f40a6fa28 ("can: kvaser_usb: Add support for Kvaser CAN/USB devices") > Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Looks good to me. Tested-by: Jimmy Assarsson <extja@kvaser.com>
> --- > drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c > index 7ed2ced8ba08..742626e69dd8 100644 > --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c > +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c > @@ -879,6 +879,10 @@ static void kvaser_usb_leaf_rx_error(const struct kvaser_usb *dev, > leaf = priv->sub_priv; > stats = &priv->netdev->stats; > > + /* Ignore e.g. state change to bus-off reported just after stopping */ > + if (!netif_running(priv->netdev)) > + return; > + > /* Update all of the CAN interface's state and error counters before > * trying any memory allocation that can actually fail with -ENOMEM. > *
|  |