Messages in this thread | | | Date | Sat, 28 May 2022 15:52:47 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3] x86/vmware: use unsigned integer for shifting |
| |
On Fri, May 27, 2022 at 11:27:37PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi <sshedi@vmware.com> > > Shifting signed 32-bit value by 31 bits is implementation-defined > behaviour. Using unsigned is better option for this.
The kernel builds with -fno-strict-overflow and as such this behaviour is well defined.
> Fixes: 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")
Nothing broken, therefore nothing fixed.
| |