lkml.org 
[lkml]   [2022]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 093/145] random: re-add removed comment about get_random_{u32,u64} reseeding
    Date
    From: "Jason A. Donenfeld" <Jason@zx2c4.com>

    commit dd7aa36e535797926d8eb311da7151919130139d upstream.

    The comment about get_random_{u32,u64}() not invoking reseeding got
    added in an unrelated commit, that then was recently reverted by
    0313bc278dac ("Revert "random: block in /dev/urandom""). So this adds
    that little comment snippet back, and improves the wording a bit too.

    Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/random.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/drivers/char/random.c
    +++ b/drivers/char/random.c
    @@ -226,9 +226,10 @@ static void _warn_unseeded_randomness(co
    *
    * These interfaces will return the requested number of random bytes
    * into the given buffer or as a return value. This is equivalent to
    - * a read from /dev/urandom. The integer family of functions may be
    - * higher performance for one-off random integers, because they do a
    - * bit of buffering.
    + * a read from /dev/urandom. The u32, u64, int, and long family of
    + * functions may be higher performance for one-off random integers,
    + * because they do a bit of buffering and do not invoke reseeding
    + * until the buffer is emptied.
    *
    *********************************************************************/


    \
     
     \ /
      Last update: 2022-05-27 14:12    [W:3.203 / U:1.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site