lkml.org 
[lkml]   [2022]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 116/145] um: use fallback for random_get_entropy() instead of zero
    Date
    From: "Jason A. Donenfeld" <Jason@zx2c4.com>

    commit 9f13fb0cd11ed2327abff69f6501a2c124c88b5a upstream.

    In the event that random_get_entropy() can't access a cycle counter or
    similar, falling back to returning 0 is really not the best we can do.
    Instead, at least calling random_get_entropy_fallback() would be
    preferable, because that always needs to return _something_, even
    falling back to jiffies eventually. It's not as though
    random_get_entropy_fallback() is super high precision or guaranteed to
    be entropic, but basically anything that's not zero all the time is
    better than returning zero all the time.

    This is accomplished by just including the asm-generic code like on
    other architectures, which means we can get rid of the empty stub
    function here.

    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Richard Weinberger <richard@nod.at>
    Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
    Acked-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/um/include/asm/timex.h | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    --- a/arch/um/include/asm/timex.h
    +++ b/arch/um/include/asm/timex.h
    @@ -2,13 +2,8 @@
    #ifndef __UM_TIMEX_H
    #define __UM_TIMEX_H

    -typedef unsigned long cycles_t;
    -
    -static inline cycles_t get_cycles (void)
    -{
    - return 0;
    -}
    -
    #define CLOCK_TICK_RATE (HZ)

    +#include <asm-generic/timex.h>
    +
    #endif

    \
     
     \ /
      Last update: 2022-05-27 14:12    [W:4.043 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site