lkml.org 
[lkml]   [2022]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 092/163] random: do not take pool spinlock at boot
    Date
    From: "Jason A. Donenfeld" <Jason@zx2c4.com>

    commit afba0b80b977b2a8f16234f2acd982f82710ba33 upstream.

    Since rand_initialize() is run while interrupts are still off and
    nothing else is running, we don't need to repeatedly take and release
    the pool spinlock, especially in the RDSEED loop.

    Reviewed-by: Eric Biggers <ebiggers@google.com>
    Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/random.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/char/random.c
    +++ b/drivers/char/random.c
    @@ -978,10 +978,10 @@ int __init rand_initialize(void)
    rv = random_get_entropy();
    arch_init = false;
    }
    - mix_pool_bytes(&rv, sizeof(rv));
    + _mix_pool_bytes(&rv, sizeof(rv));
    }
    - mix_pool_bytes(&now, sizeof(now));
    - mix_pool_bytes(utsname(), sizeof(*(utsname())));
    + _mix_pool_bytes(&now, sizeof(now));
    + _mix_pool_bytes(utsname(), sizeof(*(utsname())));

    extract_entropy(base_crng.key, sizeof(base_crng.key));
    ++base_crng.generation;

    \
     
     \ /
      Last update: 2022-05-27 14:04    [W:4.018 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site