Messages in this thread | | | Date | Fri, 27 May 2022 11:44:23 +0200 | Subject | Re: [PATCH 1/2] KVM: VMX: Sanitize VM-Entry/VM-Exit control pairs at kvm_intel load time | From | Paolo Bonzini <> |
| |
On 5/26/22 23:35, Sean Christopherson wrote: > It's not for clarity, it's to prevent plopping an EXIT control into the ENTRY > slot and vice versa. I have a hell of a time trying to visually differentiate > those, and a buggy pair isn't guaranteed to be detected at runtime, e.g. if both > are swapped, all bets are off, and if one is duplicated, odds the warn may or may > not show up unless hardware actually supports at least one of the controls, if not > both.
Make the lines longer than 80 characters and align each element so that you have a line of VM_ENTRY_ and VM_EXIT_. (It would not work if they were the same length, but they aren't).
Paolo
| |