lkml.org 
[lkml]   [2022]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH V6 2/9] virtio: use virtio_reset_device() when possible
    On Fri, May 27, 2022 at 8:01 AM Jason Wang <jasowang@redhat.com> wrote:
    >
    > This allows us to do common extension without duplicating code.
    >
    > Cc: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Peter Zijlstra <peterz@infradead.org>
    > Cc: "Paul E. McKenney" <paulmck@kernel.org>
    > Cc: Marc Zyngier <maz@kernel.org>
    > Cc: Halil Pasic <pasic@linux.ibm.com>
    > Cc: Cornelia Huck <cohuck@redhat.com>
    > Cc: Vineeth Vijayan <vneethv@linux.ibm.com>
    > Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
    > Cc: linux-s390@vger.kernel.org
    > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
    > Signed-off-by: Jason Wang <jasowang@redhat.com>

    Reviewed-by: Eugenio Pérez <eperezma@redhat.com>

    > ---
    > drivers/virtio/virtio.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
    > index 938e975029d4..aa1eb5132767 100644
    > --- a/drivers/virtio/virtio.c
    > +++ b/drivers/virtio/virtio.c
    > @@ -430,7 +430,7 @@ int register_virtio_device(struct virtio_device *dev)
    >
    > /* We always start by resetting the device, in case a previous
    > * driver messed it up. This also tests that code path a little. */
    > - dev->config->reset(dev);
    > + virtio_reset_device(dev);
    >
    > /* Acknowledge that we've seen the device. */
    > virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
    > @@ -496,7 +496,7 @@ int virtio_device_restore(struct virtio_device *dev)
    >
    > /* We always start by resetting the device, in case a previous
    > * driver messed it up. */
    > - dev->config->reset(dev);
    > + virtio_reset_device(dev);
    >
    > /* Acknowledge that we've seen the device. */
    > virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2022-05-27 10:56    [W:4.349 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site