lkml.org 
[lkml]   [2022]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[RFC PATCH 3/3] hugetlb: Lazy page table copies in fork()
Date
Lazy page table copying at fork time was introduced with commit
d992895ba2b2 ("Lazy page table copies in fork()"). At the time,
hugetlb was very new and did not support page faulting. As a result,
it was excluded. When full page fault support was added for hugetlb,
the exclusion was not removed.

Simply remove the check that prevents lazy copying of hugetlb page
tables at fork. Of course, like other mappings this only applies to
shared mappings.

Lazy page table copying at fork will be less advantageous for hugetlb
mappings because:
- There are fewer page table entries with hugetlb
- hugetlb pmds can be shared instead of copied

In any case, completely eliminating the copy at fork time shold speed
things up.

Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index 21dadf03f089..f390cc11886d 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1245,7 +1245,7 @@ vma_needs_copy(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma)
if (userfaultfd_wp(dst_vma))
return true;

- if (src_vma->vm_flags & (VM_HUGETLB | VM_PFNMAP | VM_MIXEDMAP))
+ if (src_vma->vm_flags & (VM_PFNMAP | VM_MIXEDMAP))
return true;

if (src_vma->anon_vma)
--
2.35.3
\
 
 \ /
  Last update: 2022-05-28 01:00    [W:0.200 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site