Messages in this thread | | | From | Masahiro Yamada <> | Date | Fri, 27 May 2022 23:21:02 +0900 | Subject | Re: [PATCH v7 3/8] parisc: fix the exit status of arch/parisc/nm |
| |
Hi Helge,
On Fri, May 27, 2022 at 10:58 PM Helge Deller <deller@gmx.de> wrote: > > Hello Masahiro, > > On 5/27/22 12:01, Masahiro Yamada wrote: > > parisc overrides 'nm' with a shell script. I do not know the reason, > > but anyway it is how it has worked since 2003. [1] > > I don't know the reason either... > I assume it was that the older toolchains had bugs and kept lots of local > symbols like .LC? in the object files. > > I did a small build without the nm script (and removed it's reference > in the Makefile), and it did not seem to break anything. > > > A problem is that this script returns the exit code of grep instead of > > ${CROSS_COMPILE}nm. > > Instead of fixing this, I'd suggest that you simply remove the nm script > alltogether. If you like I can apply such a patch in the parisc git tree, > and you just drop this specific patch. Or you change your patch to remove it. > Just let me know what you prefer.
This is a prerequisite of my kbuild work: https://lore.kernel.org/linux-kbuild/20220527100155.1996314-5-masahiroy@kernel.org/T/#u
Without this, ARCH=parisc builds will be broken due to ${NM} returning 1.
I will send a patch to remove arch/parisc/nm. Please give me your ack.
Thank you.
-- Best Regards Masahiro Yamada
| |