Messages in this thread | | | Date | Fri, 27 May 2022 19:29:03 +0530 | Subject | Re: [PATCH V7 0/4] mmc: add error statistics for eMMC and SD card | From | "Sajida Bhanu (Temp)" <> |
| |
On 5/27/2022 3:15 PM, Adrian Hunter wrote: > On 25/05/22 15:28, Shaik Sajida Bhanu wrote: >> Changes since V6: >> - Rebased on Ulf's(Ulf Hansson) next branch as suggested by >> Adrain Hunter. > I think maybe you re-based on the "master" branch not the "next" branch, please check Sure got it Thank you.. will re-base on next branch and post > >> - Replaced debugfs_create_file() with debugfs_create_file_unsafe() >> as suggested by Adrain Hunter. >> - "[V6,5/5] mmc: cqhci: Capture eMMC and SD card errors" not included >> in this Patch series as we don't have cqhci changes on Ulf's(Ulf Hansson) >> next branch. > cqhci is in the "next" branch, please check Sure Thank you > >> Changes since V5: >> - Considered all error stats enums to set error state. >> - Added missed tuning error related code changes which was >> missed in patch set V5 as Adrain Hunter pointed. >> - Replaced DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE >> as suggested by Adrain Hunter. >> >> Changes since V4: >> - Defined new macro to increment err_stats members when error occurred >> as suggested by Adrain Hunter. >> - Called err_stats members increment function after printing the error >> as suggested by Adrain Hunter. >> - Considered INDEX and END_BIT errors same as CRC errors as suggested >> by Adrain Hunter. >> - Removed Null check for host in debug fs functions and Reordered >> err_stats declarationas suggested by Adrain Hunter. >> - Removed err_state variable stuff and updated err_state debug fs entry >> based on the err_stats members state as suggested by Adrain Hunter. >> >> Changes since V3: >> - Dropped error stats feature flag as suggested by Adrain Hunter. >> - Separated error state related changes in separate patches as >> suggested by Adrain Hunter. >> [PATCH V4 4/7] : error state debug fs >> [PATCH V4 5/7] : error state enable function >> [PATCH V4 6/7] : error state enable in error case >> - Note: we are enabling error state before calling sdhci_dumpregs >> we couldn't add the err state in error stats array as err state >> is not error type. >> - Corrected Signed-off-by order as suggested by Bjron Andersson. >> - Moved error state enable code from sdhci_dumpregs to error >> conditions as suggested by Adrain Hunter >> >> Changes since V2: >> - Removed userspace error stats clear debug fs entry as suggested >> by Adrain Hunter. >> - Split patch into 4 patches >> [PATCH V3 1/4] : sdhci driver >> [PATCH V3 2/4] : debug fs entries >> [PATCH V3 3/4] : core driver >> [PATCH V3 4/4] : cqhci driver >> - Used for loop to print error messages instead of using printf >> statements for all error messages as suggested by Adrain Hunter. >> - Introduced one flag to enable error stats feature, if any other >> client wants to use this feature, they need to enable that flag. >> - Moved reset command timeout error statement to card init flow >> as suggested by Adrain Hunter. >> >> Changes since V1: >> - Removed sysfs entry for eMMC and SD card error statistics and added >> debugfs entry as suggested by Adrian Hunter and Ulf Hansson. >> >> Shaik Sajida Bhanu (4): >> mmc: core: Capture eMMC and SD card errors >> mmc: sdhci: Capture eMMC and SD card errors >> mmc: debugfs: Add debug fs entry for mmc driver >> mmc: debugfs: Add debug fs error state entry for mmc driver >> >> drivers/mmc/core/core.c | 11 +++++-- >> drivers/mmc/core/debugfs.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++ >> drivers/mmc/host/sdhci.c | 33 +++++++++++++++---- >> drivers/mmc/host/sdhci.h | 3 ++ >> include/linux/mmc/host.h | 26 +++++++++++++++ >> include/linux/mmc/mmc.h | 6 ++++ >> 6 files changed, 151 insertions(+), 9 deletions(-) >>
| |