Messages in this thread | | | Date | Fri, 27 May 2022 14:52:06 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] Revert "printk: wake up all waiters" |
| |
On Thu 2022-05-26 22:36:56, John Ogness wrote: > This reverts commit 938ba4084abcf6fdd21d9078513c52f8fb9b00d0. > > The wait queue @log_wait never has exclusive waiters, so there > is no need to use wake_up_interruptible_all(). Using > wake_up_interruptible() was the correct function to wake all > waiters. > > Since there are no exclusive waiters, erroneously changing > wake_up_interruptible() to wake_up_interruptible_all() did not > result in any behavior change. However, using > wake_up_interruptible_all() on a wait queue without exclusive > waiters is fundamentally wrong. > > Go back to using wake_up_interruptible() to wake all waiters. > > Signed-off-by: John Ogness <john.ogness@linutronix.de>
The patch has been committed into printk/linux.git, branch rework/printk.
I am going to create the pull request the following week after it gets at least one spin in linux-next.
It is trivial patch so that it might be sent directly. But it does not affect the functionality and is is not urgent either.
Best Regards, Petr
| |