Messages in this thread | | | From | Guo Ren <> | Date | Fri, 27 May 2022 10:48:14 +0800 | Subject | Re: [PATCH v2 1/5] riscv: drop cpufeature_apply_feature tracking variable |
| |
Safe modification.
Reviewed-by: Guo Ren <guoren@kernel.org>
On Fri, May 27, 2022 at 4:57 AM Heiko Stuebner <heiko@sntech.de> wrote: > > The variable was tracking which feature patches got applied > but that information was never actually used - and thus resulted > in a warning as well. > > Drop the variable. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/riscv/kernel/cpufeature.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > index dea3ea19deee..b33564df81e1 100644 > --- a/arch/riscv/kernel/cpufeature.c > +++ b/arch/riscv/kernel/cpufeature.c > @@ -294,7 +294,6 @@ void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, > unsigned int stage) > { > u32 cpu_req_feature = cpufeature_probe(stage); > - u32 cpu_apply_feature = 0; > struct alt_entry *alt; > u32 tmp; > > @@ -308,10 +307,8 @@ void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, > } > > tmp = (1U << alt->errata_id); > - if (cpu_req_feature & tmp) { > + if (cpu_req_feature & tmp) > patch_text_nosync(alt->old_ptr, alt->alt_ptr, alt->alt_len); > - cpu_apply_feature |= tmp; > - } > } > } > #endif > -- > 2.35.1 >
-- Best Regards Guo Ren
ML: https://lore.kernel.org/linux-csky/
| |