lkml.org 
[lkml]   [2022]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: net/dsa: Add spi-peripheral-props.yaml references
On Thu, May 26, 2022 at 03:32:16AM +0300, Vladimir Oltean wrote:
> On Wed, May 25, 2022 at 03:57:50PM -0500, Rob Herring wrote:
> > SPI peripheral device bindings need to reference spi-peripheral-props.yaml
> > in order to use various SPI controller specific properties. Otherwise,
> > the unevaluatedProperties check will reject any controller specific
> > properties.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 1 +
> > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > index 184152087b60..6bbd8145b6c1 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >
> > allOf:
> > - $ref: dsa.yaml#
> > + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> >
> > properties:
> > # See Documentation/devicetree/bindings/net/dsa/dsa.yaml for a list of additional
> > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > index 99ee4b5b9346..4f99aff029dc 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > @@ -108,6 +108,7 @@ if:
> > - reg
> >
> > then:
> > + $ref: /schemas/spi/spi-peripheral-props.yaml#
> > not:
> > required:
> > - mdc-gpios
> > --
> > 2.34.1
> >
>
> Also needed by nxp,sja1105.yaml and the following from brcm,b53.yaml:
> brcm,bcm5325
> brcm,bcm5365
> brcm,bcm5395
> brcm,bcm5397
> brcm,bcm5398
> brcm,bcm53115
> brcm,bcm53125
> brcm,bcm53128

Okay. Looks like you missed bcm5389?

Rob

\
 
 \ /
  Last update: 2022-05-27 00:06    [W:0.064 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site