lkml.org 
[lkml]   [2022]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv3 2/3] x86/tdx: Clarify RIP adjustments in #VE handler
From
On 5/26/22 13:13, Kirill A. Shutemov wrote:
>> I'm not super happy with how this comment ended up. First, let's put
>> the comment next to the code to which it applies, like:
>>
>> /*
>> * ve->instr_len is not defined for EPT violations. For those,
>> * the kernel must decode instructions manually and should not
>> * be using this function.
>> */
>> if (WARN_ON_ONCE(ve->exit_reason == EXIT_REASON_EPT_VIOLATION))
>> return 0;
>>
>> /*
>> * Assume that the #VE occurred due to instruction execution.
>> */
>> return ve->instr_len;
> Would it be helpful if the function has a whitelist of exit resons where
> using ve->instr_len is safe? WARN_ONCE() and return 0 otherwise.

Maybe. I was hoping to avoid mostly duplicating the
virt_exception_kernel() switch().

\
 
 \ /
  Last update: 2022-05-26 22:19    [W:0.142 / U:3.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site