Messages in this thread | | | Date | Thu, 26 May 2022 10:23:40 +0300 | Subject | Re: [PATCH v2] coresight: etm4x: Add Support for HiSilicon ETM device | From | Alexei Budankov <> |
| |
Hi Qi,
On 26.05.2022 5:56, liuqi (BA) wrote: > > Hi Alexei, > > On 2022/5/25 23:10, Alexei Budankov wrote: >> >> Hi Qi Liu, >> >> On 13.08.2020 15:59, Qi Liu wrote: >>> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08 >>> contains ETMv4.2 device and Hip09 contains ETMv4.5 device. >>> >>> Signed-off-by: Qi Liu <liuqi115@huawei.com> >>> --- >>> drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Thanks for your patch. >> I would like to test HiSilicon ETM device feature on >> Kunpeng 920 based server. >> I applied the patch and booted the kernel with the changes. >> However I don't see any device files neither here: >> /sys/bus/coresight/devices/ > > Thanks for your test :)
Thanks for quick reply. Appreciate it much. :)
> > Kunpeng 920 platform(Non-PG) support tracing CPU instruction, source device is coresight ETM, link device is coresight funnel and sink device is ultrasoc SMB. So you need to insmod coresight-* driver and SMB driver, which patch is : > Add support for UltraSoc System Memory Buffer > https://lore.kernel.org/linux-arm-kernel/20220416083953.52610-1-liuqi115@huawei.com/
I will try it shortly and let you know.
> > by the way, can you help to check /sys/bus/amba/devices/, and make sure that the firmware of your board has supported ETM, funnel and SMB devices?
Here we go:
huawei@armubuntu:~$ pwd /home/huawei huawei@armubuntu:~$ ls /sys/bus/amba/devices/ huawei@armubuntu:~$
Look like our server firmware should be upgraded, right? Your help and support is greatly appreciated.
Thanks, Alexei
> > Thanks, > Qi > >> nor here: >> /sys/bus/event_source/devices/cs_etm/sinks/ >> What should a user expect new in os with this patch added? > > >> >> Thanks, >> Alexei >> > > >> >>> >>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c >>> index 6d7d216..7797a57 100644 >>> --- a/drivers/hwtracing/coresight/coresight-etm4x.c >>> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c >>> @@ -1587,6 +1587,8 @@ static const struct amba_id etm4_ids[] = { >>> CS_AMBA_UCI_ID(0x000bb805, uci_id_etm4),/* Qualcomm Kryo 4XX Cortex-A55 */ >>> CS_AMBA_UCI_ID(0x000bb804, uci_id_etm4),/* Qualcomm Kryo 4XX Cortex-A76 */ >>> CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */ >>> + CS_AMBA_UCI_ID(0x000b6d01, uci_id_etm4),/* HiSilicon-Hip08 */ >>> + CS_AMBA_UCI_ID(0x000b6d02, uci_id_etm4),/* HiSilicon-Hip09 */ >>> {}, >>> }; >>> >>> -- >>> 2.8.1 >> . > .
| |