lkml.org 
[lkml]   [2022]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] thermal: k3_j72xx_bandgap: Fix ref_table memory leak during probe
From


On 5/26/2022 3:06 AM, Bryan Brattlof wrote:
> If an error occurs in the k3_j72xx_bandgap_probe() function the memory
> allocated to the 'ref_table' will not be released.
>
> Add a err_free_ref_table step to the error path to free 'ref_table'

Reviewed-by: Keerthy <j-keerthy@ti.com>

>
> Fixes: 72b3fc61c752 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Bryan Brattlof <bb@ti.com>
> ---
> drivers/thermal/k3_j72xx_bandgap.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
> index 64e3231589527..3a35aa38ff512 100644
> --- a/drivers/thermal/k3_j72xx_bandgap.c
> +++ b/drivers/thermal/k3_j72xx_bandgap.c
> @@ -433,7 +433,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
> GFP_KERNEL);
> if (!derived_table) {
> ret = -ENOMEM;
> - goto err_alloc;
> + goto err_free_ref_table;
> }
>
> /* Workaround not needed if bit30/bit31 is set even for J721e */
> @@ -483,7 +483,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
> if (IS_ERR(ti_thermal)) {
> dev_err(bgp->dev, "thermal zone device is NULL\n");
> ret = PTR_ERR(ti_thermal);
> - goto err_alloc;
> + goto err_free_ref_table;
> }
> }
>
> @@ -514,6 +514,9 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
>
> return 0;
>
> +err_free_ref_table:
> + kfree(ref_table);
> +
> err_alloc:
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);

\
 
 \ /
  Last update: 2022-05-26 17:00    [W:0.036 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site