Messages in this thread | | | From | Carlos Fernandez <> | Subject | Re: [PATCH net] net: macsec: Retrieve MACSec-XPN attributes before offloading | Date | Thu, 26 May 2022 12:21:36 +0000 |
| |
Thanks, Paolo. I'll add the tag and resend it again.
________________________________________ From: Paolo Abeni <pabeni@redhat.com> Sent: Thursday, May 26, 2022 10:59 AM To: Carlos Fernandez Cc: Carlos Fernandez; David S. Miller; Eric Dumazet; Jakub Kicinski; Era Mayflower; open list:NETWORKING DRIVERS; open list Subject: Re: [PATCH net] net: macsec: Retrieve MACSec-XPN attributes before offloading
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
On Tue, 2022-05-24 at 13:41 +0200, Carlos Fernandez wrote: > When MACsec offloading is used with XPN, before mdo_add_rxsa > and mdo_add_txsa functions are called, the key salt is not > copied to the macsec context struct. Offloaded phys will need > this data when performing offloading. > > Fix by copying salt and id to context struct before calling the > offloading functions. > > Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites") > Signed-off-by: Carlos Fernandez <carlos.fernandez@technica-engineering.de>
I'm sorry to nick-picking again, but this patch don't pass checkpatch validation:
https://patchwork.kernel.org/project/netdevbpf/patch/20220524114134.366696-1-carlos.fernandez@technica-engineering.de/
Specifically, you should add a 'From:' tag as the first line:
From: Carlos Fernandez <carlos.fernandez@technica-engineering.de>
(Or send this patch from the above email address)
Thanks!
| |