Messages in this thread | | | Date | Thu, 26 May 2022 12:15:36 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2] cpu/hotplug: Do not bail-out in DYING/STARTING sections |
| |
On Thu, May 26, 2022 at 09:24:28AM +0100, Vincent Donnefort wrote: > On Wed, May 25, 2022 at 06:52:48PM +0200, Peter Zijlstra wrote: > > On Mon, May 23, 2022 at 05:05:36PM +0100, Vincent Donnefort wrote: > > > The DYING/STARTING callbacks are not expected to fail. However, as reported > > > by Derek, drivers such as tboot are still free to return errors within > > > those sections. In that case, there's nothing the hotplug machinery can do, > > > so let's just proceed and log the failures. > > > > > > > I'm confused. Why isn't this a driver bug? > > It is a entirely a driver bug which has been reported already. but 453e41085183 > (cpu/hotplug: Add cpuhp_invoke_callback_range()) changed the behaviour so I > thought it would be worth to revert to the original one which is to not break > the entire up/down for a single driver error.
Ah I see. Fair enough I suppose.
| |