Messages in this thread | | | Subject | Re: [PATCH v2 3/3] clk: qcom: lpass: Add support for resets & external mclk for SC7280 | From | Stephen Boyd <> | Date | Wed, 25 May 2022 10:54:50 -0700 |
| |
Quoting Taniya Das (2022-05-23 02:23:14) > diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c > index 6ab6e5a34c72..536509b78341 100644 > --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c > +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c > static const struct of_device_id lpass_audio_cc_sc7280_match_table[] = { > { .compatible = "qcom,sc7280-lpassaudiocc" }, > { } > @@ -741,6 +754,8 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev) > return ret; > } > > + ret = qcom_cc_probe_by_index(pdev, 1, &lpass_audio_cc_reset_sc7280_desc);
What if it fails? Shouldn't we pm_runtime_disable()?
> + > pm_runtime_mark_last_busy(&pdev->dev); > pm_runtime_put_autosuspend(&pdev->dev); > pm_runtime_put_sync(&pdev->dev);
| |