Messages in this thread | | | Date | Wed, 25 May 2022 12:46:30 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v3 4/7] arm64: dts: qcom: sdm845: control RPMHPD performance states with UFS |
| |
On 13-05-22, 08:13, Krzysztof Kozlowski wrote: > + ufs_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-50000000 { > + opp-hz = /bits/ 64 <50000000 > + 0 > + 0 > + 37500000 > + 0 > + 0 > + 0 > + 0 > + // FIXME: value 0 copied from freq-table-hz > + 0>;
One general comment, I think this should follow how we specify multiple voltages or other fields and so each frequency should be part of a different < > braces. Like: opp-hz = /bits/ 64 <5000000>, <0>, ....
Whatever is there between < > seems to be connected, like min/max/target for voltage.
The code will process both in a similar way though eventually.
-- viresh
| |