Messages in this thread | | | Date | Thu, 26 May 2022 08:17:41 +0530 | From | Pavan Kondeti <> | Subject | Re: [PATCH v18 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status |
| |
On Wed, May 25, 2022 at 11:50:26PM +0530, Krishna Kurapati wrote: > From: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > > If dwc3 is wakeup capable, keep the power domain always ON so that > wakeup from system suspend can be supported. Otherwise, keep the > power domain ON only during runtime suspend to support wakeup from > runtime suspend. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > drivers/usb/dwc3/dwc3-qcom.c | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > <snip>
> - device_init_wakeup(&pdev->dev, 1); > + if (device_can_wakeup(&qcom->dwc3->dev)) { > + /* > + * Setting GENPD_FLAG_ALWAYS_ON flag takes care of keeping > + * GEMPD on in both RT suspend and System suspend cases.
Few typos, otherwise looks good to me.
%s/GEMPD/genpd
%s/RT/runtime
%s/System/system
Thanks, Pavan
| |