lkml.org 
[lkml]   [2022]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/5] Bluetooth: aosp: surface AOSP quality report through mgmt
Hi Joseph,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on net-next/master net/master v5.18 next-20220525]
[cannot apply to bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Joseph-Hwang/Bluetooth-mgmt-add-MGMT_OP_SET_QUALITY_REPORT-for-quality-report/20220525-184722
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220526/202205260445.F8Xkowrk-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-14-g5a0004b5-dirty
# https://github.com/intel-lab-lkp/linux/commit/0121eca73c0352b9ac4bc289609b218c0d0fb69e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Joseph-Hwang/Bluetooth-mgmt-add-MGMT_OP_SET_QUALITY_REPORT-for-quality-report/20220525-184722
git checkout 0121eca73c0352b9ac4bc289609b218c0d0fb69e
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash net/bluetooth/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
net/bluetooth/hci_event.c:338:15: sparse: sparse: restricted __le16 degrades to integer
>> net/bluetooth/hci_event.c:4275:3: sparse: sparse: symbol 'evt_prefixes' was not declared. Should it be static?
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
include/net/bluetooth/hci.h:2494:47: sparse: sparse: array of flexible structures
include/net/bluetooth/hci.h:2580:43: sparse: sparse: array of flexible structures

vim +/evt_prefixes +4275 net/bluetooth/hci_event.c

4262
4263 /* Every distinct vendor specification must have a well-defined vendor
4264 * event prefix to determine if a vendor event meets the specification.
4265 * Some vendor prefixes are fixed values while some other vendor prefixes
4266 * are only available at run time.
4267 */
4268 struct ext_vendor_event_prefix {
4269 /* Some vendor prefixes are variable length. For convenience,
4270 * the prefix in struct ext_vendor_prefix is in little endian.
4271 */
4272 struct ext_vendor_prefix *
4273 (*get_ext_vendor_prefix)(struct hci_dev *hdev);
4274 void (*vendor_func)(struct hci_dev *hdev, struct sk_buff *skb);
> 4275 } evt_prefixes[] = {
4276 { aosp_get_ext_prefix, aosp_vendor_evt },
4277 { msft_get_ext_prefix, msft_vendor_evt },
4278
4279 /* end with a null entry */
4280 {},
4281 };
4282

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-25 22:17    [W:0.055 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site