Messages in this thread | | | Date | Tue, 24 May 2022 13:56:16 -0700 | Subject | Re: arch/riscv/mm/init.c:782:83: warning: suggest braces around empty body in an 'if' statement | From | Randy Dunlap <> |
| |
Hi Palmer,
On 5/22/22 14:19, kernel test robot wrote: > Hi Qinglin, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f > commit: 677b9eb8810edc6c616a699018a83e24ed0cccab riscv: mm: Prepare pt_ops helper functions for sv57 > date: 3 months ago > config: riscv-randconfig-r042-20220522 (https://download.01.org/0day-ci/archive/20220523/202205230554.bQhtkCTA-lkp@intel.com/config) > compiler: riscv32-linux-gcc (GCC) 11.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=677b9eb8810edc6c616a699018a83e24ed0cccab > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git fetch --no-tags linus master > git checkout 677b9eb8810edc6c616a699018a83e24ed0cccab > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/mm/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > arch/riscv/mm/init.c: In function 'create_fdt_early_page_table': >>> arch/riscv/mm/init.c:782:83: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] > 782 | (uintptr_t)early_dtb_pud, P4D_SIZE, PAGE_TABLE); > | ^ > arch/riscv/mm/init.c:786:83: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] > 786 | (uintptr_t)early_dtb_pmd, PUD_SIZE, PAGE_TABLE); > | ^ > arch/riscv/mm/init.c: At top level: > arch/riscv/mm/init.c:813:13: warning: no previous prototype for 'pt_ops_set_early' [-Wmissing-prototypes] > 813 | void __init pt_ops_set_early(void) > | ^~~~~~~~~~~~~~~~ > arch/riscv/mm/init.c:835:13: warning: no previous prototype for 'pt_ops_set_fixmap' [-Wmissing-prototypes] > 835 | void __init pt_ops_set_fixmap(void) > | ^~~~~~~~~~~~~~~~~ > arch/riscv/mm/init.c:853:13: warning: no previous prototype for 'pt_ops_set_late' [-Wmissing-prototypes] > 853 | void __init pt_ops_set_late(void) > | ^~~~~~~~~~~~~~~
What is the status of your patch for this build warning?
[PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions
Thanks.
-- ~Randy
| |