lkml.org 
[lkml]   [2022]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/5] iio: treewide: rearrange iio trig get/register
Date
The following patchset resolves problems with iio_trigger_get() and
iio_trigger_register() call order in the different IIO drivers.

IIO trigger interface function iio_trigger_get() should be called after
iio_trigger_register() (or its devm analogue) strictly, because of
iio_trigger_get() acquires module refcnt based on the trigger->owner
pointer, which is initialized inside iio_trigger_register() to
THIS_MODULE.
If this call order is wrong, the next iio_trigger_put() (from sysfs
callback or "delete module" path) will dereference "default" module
refcnt, which is incorrect behaviour.

Changes v1->v2:
- provide tag Fixes: for all patches

Dmitry Rokosov (5):
iio:accel:bma180: rearrange iio trigger get and register
iio:accel:kxcjk-1013: rearrange iio trigger get and register
iio:accel:mxc4005: rearrange iio trigger get and register
iio:chemical:ccs811: rearrange iio trigger get and register
iio:humidity:hts221: rearrange iio trigger get and register

drivers/iio/accel/bma180.c | 3 ++-
drivers/iio/accel/kxcjk-1013.c | 4 ++--
drivers/iio/accel/mxc4005.c | 4 ++--
drivers/iio/chemical/ccs811.c | 4 ++--
drivers/iio/humidity/hts221_buffer.c | 5 ++++-
5 files changed, 12 insertions(+), 8 deletions(-)

--
2.36.0

\
 
 \ /
  Last update: 2022-05-24 20:16    [W:0.227 / U:1.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site