lkml.org 
[lkml]   [2022]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/5] iio:accel:mxc4005: rearrange iio trigger get and register
    Date
    IIO trigger interface function iio_trigger_get() should be called after
    iio_trigger_register() (or its devm analogue) strictly, because of
    iio_trigger_get() acquires module refcnt based on the trigger->owner
    pointer, which is initialized inside iio_trigger_register() to
    THIS_MODULE.
    If this call order is wrong, the next iio_trigger_put() (from sysfs
    callback or "delete module" path) will dereference "default" module
    refcnt, which is incorrect behaviour.

    Fixes: 47196620c82f ("iio: mxc4005: add data ready trigger for mxc4005")
    Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
    ---
    drivers/iio/accel/mxc4005.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
    index b3afbf064915..df600d2917c0 100644
    --- a/drivers/iio/accel/mxc4005.c
    +++ b/drivers/iio/accel/mxc4005.c
    @@ -456,8 +456,6 @@ static int mxc4005_probe(struct i2c_client *client,

    data->dready_trig->ops = &mxc4005_trigger_ops;
    iio_trigger_set_drvdata(data->dready_trig, indio_dev);
    - indio_dev->trig = data->dready_trig;
    - iio_trigger_get(indio_dev->trig);
    ret = devm_iio_trigger_register(&client->dev,
    data->dready_trig);
    if (ret) {
    @@ -465,6 +463,8 @@ static int mxc4005_probe(struct i2c_client *client,
    "failed to register trigger\n");
    return ret;
    }
    +
    + indio_dev->trig = iio_trigger_get(data->dready_trig);
    }

    return devm_iio_device_register(&client->dev, indio_dev);
    --
    2.36.0
    \
     
     \ /
      Last update: 2022-05-24 20:16    [W:4.637 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site