Messages in this thread | | | Date | Tue, 24 May 2022 11:14:46 -0700 | From | Josh Poimboeuf <> | Subject | Re: [GIT PULL] objtool changes for v5.19 |
| |
On Tue, May 24, 2022 at 08:08:05PM +0200, Peter Zijlstra wrote: > On Tue, May 24, 2022 at 10:53:40AM -0700, Linus Torvalds wrote: > > On Mon, May 23, 2022 at 11:02 PM Ingo Molnar <mingo@kernel.org> wrote: > > > > > > Note that with your latest tree you'll get 3 new conflicts: > > > > No problem, but the conflicts did make something clear: the objtool > > code should just get rid of the "--uaccess" flag that is now > > unconditional when CONFIG_X86_SMAP has been removed. > > > > I didn't actually do that, and instead just did the mindless merge > > conflict resolution, but it might be a good idea. > > Yes, I think there is patch pending for that, but given the total merge > pain we already had, I was waiting for all the dust to settle before > taking it further.
Actually I think we should go the other direction by keeping '--uaccess' and adding CONFIG_HAVE_UACCESS_VALIDATION or so. The main point of that objtool rewrite was to make all the features modular so other arches could port them piecemeal.
-- Josh
| |